search

r-spatial / sftime

time extension to sf objects
https://r-spatial.github.io/sftime/
Apache License 2.0
49 stars 5 forks source link

Allowed combinations in `c.tc()` and `[<-.tc` #8

Closed henningte closed 2 years ago

henningte commented 2 years ago

The current implementation for c.tc() (#6) takes a very conservative approach, allowing to combine two tc objects only if the underlying classes are identical (to avoid possible inconsistencies when merging e.g. factors with POSIXct, or Dates with POSIXct).

Do you think this is a sensible approach?

The same question is relevant for [<-.tc which currently allows all values to be entered which can be entered into objects of the underlying class of the tc object.

henningte commented 2 years ago

Closing this issue because the tc class is deprecated now.