r-spatial / spatialreg

spatialreg: spatial models estimation and testing
https://r-spatial.github.io/spatialreg/
43 stars 11 forks source link

Impacts SDEM and SLX with lagged intercept #14

Closed ruettenauer closed 3 years ago

ruettenauer commented 4 years ago

First commit https://github.com/r-spatial/spatialreg/commit/4336121111331eed93e9f84a2054cf1c0472da7c solves issue #13 of saving wrong coefficients as impacts in lmSLX() and errorsarlm(), and second commit https://github.com/r-spatial/spatialreg/commit/0b5656f65165d728812758b0b11ef66fa2ffef52 allows for a generally more flexible intercept handling in lmSLX(). All performed tests are available in https://github.com/ruettenauer/mixed I hope it helps, but I'm happy to adapt / add new tests if required. Best, Tobias

rsbivand commented 4 years ago

Thanks, I'll take a look next week, busy with rgdal fall-out now.