search

r-spatial / spatialreg

spatialreg: spatial models estimation and testing
https://r-spatial.github.io/spatialreg/
41 stars 12 forks source link

Impact methods #16

Closed gpiras closed 3 years ago

gpiras commented 3 years ago

Hi Roger,

this is a version that accommodates for the impacts from sphet. The two major changes are:

  1. Both processsamples() and processXsamples() have been changed. However, as I mentioned already in our previous conversations, the zero_fill arguments from sphet takes the form of a list. For that reason, it was easy to add a condition to the function and leave unchanged the existing code.
  2. Second, I added a function that's called mixedImpacts_e that uses eigenvalues for the Durbin model except when the trace is the only argument specified. As a consequence the functions lagImpactsExact and MixedImpactsExact are not longer used. Please let me know if I need to be more specific. Best, Gianfranco
rsbivand commented 3 years ago

This will take a long time to review. Many of the changes seem to be simply formatting, which makes it hard to see what has actually changed. I'll need to step back and instrument tests for the pre-PR expected behaviour, then try to detect any regressions, then work out what caused them.