search

r-sugi / nextjs-tdd-template

https://nextjs-tdd-templatestorybook-rsugis-projects.vercel.app
0 stars 0 forks source link

CI/CD actionsの実行時間を最適化する（主にcache） #191

Closed r-sugi closed 2 months ago

r-sugi commented 2 months ago

User description

189

PR Type

bug_fix, enhancement

Description

Changes walkthrough 📝

Relevant files
Bug fix
lint.yml
Correct path for setup-node-modules in lint workflow         
.github/workflows/lint.yml
  • Fixed the path to setup-node-modules.yml by adding a leading ./.
    		•  +1/-1     
    storybook.yml
    Correct path for setup-node-modules in storybook workflow
    .github/workflows/storybook.yml
  • Fixed the path to setup-node-modules.yml by adding a leading ./.
    		•  +1/-1     
    Enhancement
    unit-test.yml
    Correct path and update paths configuration in unit-test workflow
    .github/workflows/unit-test.yml
  • Fixed the path to setup-node-modules.yml by adding a leading ./.
  • Updated the paths configuration for pull requests.
    		•  +2/-2     

    💡 PR-Agent usage: Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

    vercel[bot] commented 2 months ago

    The latest updates on your projects. Learn more about Vercel for Git ↗︎

    Name Status Preview Comments Updated (UTC)
    nextjs-tdd-template_storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 10, 2024 8:12am
    github-actions[bot] commented 2 months ago

    PR Reviewer Guide 🔍

    ⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
    🧪 No relevant tests
    🔒 No security concerns identified
    ⚡ No key issues to review
    github-actions[bot] commented 2 months ago

    PR Code Suggestions ✨

    CategorySuggestion                                                                                                                                    Score
    Best practice
    パスの一貫性を保つために、不要な ./ を削除します。 ___ **パスの先頭にある `./` を削除して、他のワークフローと一貫性を保ちます。** [.github/workflows/lint.yml [17]](https://github.com/r-sugi/nextjs-tdd-template/pull/191/files#diff-107e910e9f2ebfb9a741fa10b2aa7100cc1fc4f5f3aca2dfe78b905cbd73c0d2R17-R17) ```diff -- uses: ./.github/workflows/shared/setup-node-modules.yml +- uses: .github/workflows/shared/setup-node-modules.yml ```
    Suggestion importance[1-10]: 9 Why: The suggestion improves consistency across workflow files by removing the unnecessary `./` prefix, aligning with the existing pattern in other workflow files. This enhances maintainability and readability.
    		9