Open mtennekes opened 5 months ago
I'm not sure on the threshold for a "different result". I include an example below. If it's not "different" then please say so! This is for a point dataset with the qtm()
defaults:
v3
v4
crimes <- read.csv("http://nickbearman.me.uk/data/r/police-uk-2020-04-merseyside-street.csv")
crimes_sf <- st_as_sf(crimes, coords = c('Longitude', 'Latitude'), crs = 4326)
qtm(crimes_sf)
Thanks for bringing this up @nickbearman
Apparently, the spatial points are treated like bubbles (v4) instead of dots (v3) by qtm
. Not sure what the reason was, and I can change it back.
Apart from backward compatibility, what do you like more / find more useful? In your example, the dots work better, but what if there are only a handful of points?
Thanks @mtennekes
Good question. I think ideally if there are a small number of items then use bubbles, where as if there are a large number of items use dots. This would probably provide the best user experience, but I appreciate it makes qtm()
more complicated and you may not want this!
For info, my example above had 13,650 observations in it.
So perhaps <250 use bubbles, otherwise use dots might be a good approach?
Thanks for all the work your doing!
qtm
is quite hard to reimplement due to backward compatibility. In v3 there were trillions of arguments that could be passed on, and also in v4, so quite complex to get it right.Related to #861 : I'm not aiming for exact code translation (which is hard) but low level learning tips, that I think is also more useful from an educational point of view.
This one from #851 is working well:
This to do's for
qtm
: facets and baseman's.Please use this issue to post examples of
qtm
that don't work as expected or that give a different result than in v3.