search

r-transit / tidytransit

R package for working with GTFS data
https://r-transit.github.io/tidytransit/
150 stars 22 forks source link

added retry logic to HTTP requests #131

Closed jameslamb closed 5 years ago

jameslamb commented 5 years ago

Thanks for this cool package! Would you consider a change to use httr::RETRY() instead of httr::GET() for HTTP requests?

This will make the package more resilient to transient problems like brief network outages or periods where the service(s) it hits are overwhelmed. In my experience, using retry logic can improve the user experience with HTTP clients.

I'm sorry about the whitespace changes in this PR...those are something I do in my IDE by default. Figured they are harmless but if you'd like me to revert them please let me know and I'd be happy to.

tbuckl commented 5 years ago

great idea @jameslamb. @polettif i'm ok to merge this if you are.

polettif commented 5 years ago

Sounds good, thank you @jameslamb