search

r-transit / tidytransit

R package for working with GTFS data
https://r-transit.github.io/tidytransit/
149 stars 21 forks source link

filter_feed_by_* and write sf objects to csv #168

Closed polettif closed 3 years ago

polettif commented 3 years ago

This PR adds filter_feed_by_* functions that can be used to create a subset of a feed based on trips running through an area or using certain stops:

travel_times now also accepts a feed filtered by filter_feed_by_date

I've also done some restructuring with spatial functions:

polettif commented 3 years ago

After thinking about it, filter_feed_by... sounds better because existing filter functions (like filter_stop_times or filter_stops) return just one table and not the whole feed.

I guess windows-latest (devel) keeps failing because there are packages missing for that version but I can't really tell.

codecov-commenter commented 3 years ago

Codecov Report

Merging #168 (4475663) into master (7139cde) will increase coverage by 27.00%. The diff coverage is 100.00%.

:exclamation: Current head 4475663 differs from pull request most recent head d081c62. Consider uploading reports for the commit d081c62 to get more accurate results Impacted file tree graph

@@             Coverage Diff             @@
##           master     #168       +/-   ##
===========================================
+ Coverage   61.57%   88.57%   +27.00%     
===========================================
  Files          13       13               
  Lines         968     1042       +74     
===========================================
+ Hits          596      923      +327     
+ Misses        372      119      -253
Impacted Files Coverage Δ
R/service.R 70.96% <ø> (+8.11%) :arrow_up:
R/time.R 100.00% <ø> (+5.55%) :arrow_up:
R/utils.R 100.00% <ø> (+67.56%) :arrow_up:
R/io.R 100.00% <100.00%> (ø)
R/joins.R 100.00% <100.00%> (ø)
R/raptor.R 100.00% <100.00%> (ø)
R/spatial.R 100.00% <100.00%> (ø)
R/summary.R 100.00% <0.00%> (+13.95%) :arrow_up:
R/spec.R 100.00% <0.00%> (+100.00%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 7139cde...d081c62. Read the comment docs.

polettif commented 3 years ago

Vignette's not yet ready but I think we can still merge, even if windows-devel is somehow failing, what do you think @tbuckl?

tbuckl commented 3 years ago

@polettif sorry i have been too busy to review this recently. i don't see that changing anytime soon. lets discuss transferring review and maintenance tasks.