search

r-transit / tidytransit

R package for working with GTFS data
https://r-transit.github.io/tidytransit/
147 stars 21 forks source link

fix tests and put package back on CRAN #169

Closed bpb824 closed 3 years ago

bpb824 commented 3 years ago

Is anyone working on resolving the unit test failures? I could help but don't want to duplicate work.

https://cran.r-project.org/web/packages/tidytransit/index.html

tbuckl commented 3 years ago

.

polettif commented 3 years ago

The issue has been fixed in this commit on #168. I wasn't aware of it and encountered it while working on the branch, so I don't recall what the issue was exactly. Are there any other fixes necessary?

The development branch is still failing, so maybe a hotfix to get this back on CRAN is the way to go?

polettif commented 3 years ago

The development branch is still failing, so maybe a hotfix to get this back on CRAN is the way to go?

*** arch - i386
Error: Error: package or namespace load failed for 'tidytransit' in library.dynam(lib, package, package.lib):
 DLL 'datatable' not found: maybe not installed for this architecture?
Error: Error: loading failed

This seems to be an issue with datatable on windows-latest (devel), 3.6 and 4.0 run fine. So I think we could merge #168

polettif commented 3 years ago

v1.1 is ready to go. However, there is some (unexpected) additional documentation required, so the CRAN release is still in progress.

polettif commented 3 years ago

v1.1 is on CRAN ✅