search

r-transit / tidytransit

R package for working with GTFS data
https://r-transit.github.io/tidytransit/
143 stars 21 forks source link

Revdep check failure #209

Closed rsbivand closed 9 months ago

rsbivand commented 9 months ago

With forthcoming GDAL 3.8.1 and PROJ 9.3.1, and sf HEAD, test failures: 00check.log testthat.Rout.zip

Error: processing vignette 'frequency.Rmd' failed with diagnostics: all(is.na(x)) is not TRUE

may be similar to https://github.com/alarm-redist/redist/issues/175 @edzer? These two (so far) revdeps suggest that packages adding class names to sf objects (and using tibble?) go to default rather than sf, and mess up the agr values ?? 1.0-14 was published prior to https://github.com/r-spatial/sf/commit/b301342ae472e93db905f9cc4546d84cab2283ac and subsequent. Are they rather sf issues?

polettif commented 9 months ago

Is there anything we need to do now on tidytransit?

edzer commented 9 months ago

Fixing #210 would be great - I think that was the only issue left.