search

r-universe-org / help

Support and bug tracker for R-universe
https://docs.r-universe.dev/
9 stars 2 forks source link

Update submodules: fails with `HTTP error 404` during `Sync Registry` step #169

Closed mrustl closed 2 years ago

mrustl commented 2 years ago

Hi @jeroen,

any idea why this is happening in our KWB-R universe?:

ERROR updating pkgmeta from https://github.com/KWB-R/pkgmeta (HTTP error 404.)

https://github.com/r-universe/kwb-r/runs/6696970052?check_suite_focus=true#step:3:131

jeroen commented 2 years ago

It is unable to find the DESCRIPTION file in one of your remotes: https://raw.githubusercontent.com/UptakeOpenSource/pkgnet/HEAD/DESCRIPTION

mrustl commented 2 years ago

Thanks! Seems they renamed their GitHub org . How did you find out so quickly? From the GH actions log the reason was not very obvious to me.

jeroen commented 2 years ago

I think the problem is that the packages lives in a subdir of the remote git repo, which is not specified.

Yeah the output is a bit unclear, because the error gets postponed to the end until all packages are processed. But if you scroll up a git in the log you can see the urls that it is trying to download, so that is where the error happend. I'll try to make that more clear

mrustl commented 2 years ago

Very cool! And thanks for your fast response!

well interestingly installing from GitHub using remotes is working for both:

remotes::install_github("UptakeOpenSource/pkgnet@d1e974de299d46e71b082e027a71b8b254edc9b2")
remotes::install_github("uptake/pkgnet@d1e974de299d46e71b082e027a71b8b254edc9b2")

Maybe the redirect from https://github.com/UptakeOpenSource/pkgnet to https://github.com/uptake/pkgnet is not handled by r-universe?

jeroen commented 2 years ago

Yes we use the raw github api, which apparently doesn't do redirecting: https://raw.githubusercontent.com/UptakeOpenSource/pkgnet/HEAD/DESCRIPTION

jeroen commented 2 years ago

Looks like your registry has been fixed!

mrustl commented 2 years ago

Yeah working again. Maybe this is something for the FAQ as the behavior of raw github api and remotes::install_github() differs, so there is no way to find beforehand using GH CI that there is a renaming issue with the dependency!

jeroen commented 2 years ago

I'm not super happy with the "remotes" way of specifying dependencies actually. We added it to support some common practices but it would be better to explicitly add your extra dependencies to the registry, so that we don't have to derive them from the decription files. So maybe this is something that will change in the future...