search

r-universe-org / help

Support and bug tracker for R-universe
https://docs.r-universe.dev/
9 stars 2 forks source link

failed builds require new package version to update package source #392

Closed JosiahParry closed 5 months ago

JosiahParry commented 5 months ago

I'm trying to get a new build of my package working on r-universe. however the package build has failed (which is totally fine). I've pushed a change to the makevars to fix it and pressed the retry build button. However, this appears to use the cached source from the previous failed build. It requires a new package version in order for a the source to be updated.

Is there a way for this caching of package source to not happen for failed package builds? So that a package does not need to have its version incremented for a bad build?

jeroen commented 5 months ago

The package source will automatically get updated approximately every hour. Did you push the fix over an hour ago?

If there is a problem please link to the build log.

jeroen commented 5 months ago

Did your problem get fixed? Can you please close the issue if it did.

JosiahParry commented 5 months ago

No, it didnt but it sounds like its as designed.

jeroen commented 5 months ago

So can you link to the failing build please?

Op vr 5 apr. 2024 16:53 schreef Josiah Parry @.***>:

No, it didnt but it sounds like its as designed.

— Reply to this email directly, view it on GitHub https://github.com/r-universe-org/help/issues/392#issuecomment-2040006288, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABUZ7Y2MOC7VHCVQKBDNP3Y323FTAVCNFSM6AAAAABFXHK7D2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBQGAYDMMRYHA . You are receiving this because you modified the open/close state.Message ID: @.***>

JosiahParry commented 5 months ago

My apologies for not getting back to you. This is the build I was trying to debug https://github.com/r-universe/josiahparry/actions/runs/8555402708/job/23512987135.

The build works locally with the webR docker image and the patched crates.io path but not using the r-universe builder.

JosiahParry commented 4 months ago

I'm running into frustrations with this again. I think I understand what is bothering me. Its not necessarily that I have to wait 1 hr for a new build to occur. But rather, if all of my builds are failing, I must bump the version of the package for the package to get updated at the hour marker. I would prefer that r-universe would update and retry failed builds at the hour marker.

jeroen commented 4 months ago

You don't need to update the version, that is completely ignored. r-universe will check every hour if the latest commit in the branch it is tracking has changed. If you have pushed new commits, it will trigger a new build.