Adding brotli based on MSYS2 package.

r-windows / rtools-packages

Toolchains and libraries for R-4.0 to R-4.2 (legacy)

https://cran.r-project.org/bin/windows/Rtools/rtools40.html

BSD 3-Clause "New" or "Revised" License

54 stars 36 forks source link

Adding brotli based on MSYS2 package. #232

Closed wjones127 closed 2 years ago

wjones127 commented 2 years ago

[x] Copied over from https://github.com/msys2/MINGW-packages/blob/master/mingw-w64-brotli/PKGBUILD
[x] Removed dynamic libraries from build
[x] Validated build with makepkg-mingw -sCLf (i686 and x64)

jeroen commented 2 years ago

Thanks. Removing the static libraries hasn't worked; the artifacts still contain .dll and .dll.a files. Why do you build with

-DBUILD_{SHARED,STATIC}_LIBS=ON

We should only build static libs.

Also I think we don't need the python bindings, it would probably be better if we don't depend on python in this package. Maybe we can drop the package_python-brotli package, or do you need this?

wjones127 commented 2 years ago

Also I think we don't need the python bindings, it would probably be better if we don't depend on python in this package. Maybe we can drop the package_python-brotli package, or do you need this?

That's fair. I will look into dropping that.

jeroen commented 2 years ago

Thanks!