r-windows / rtools-packages

Toolchains and libraries for R-4.0 to R-4.2 (legacy)
https://cran.r-project.org/bin/windows/Rtools/rtools40.html
BSD 3-Clause "New" or "Revised" License
54 stars 36 forks source link

Update PKGBUILD #250

Closed jeroen closed 2 years ago

astamm commented 2 years ago

Thanks for merging the PR and cleaning up the script. Is there something to be done for putting it on rwinlib from here?

jeroen commented 2 years ago

I have put a copy here: https://github.com/rwinlib/vtk

You can use the following in your PKG_LIBS in your R package Makevars.win to link to the correct library:

    -L$(RWINLIB)/lib${subst gcc,,${COMPILED_BY}}${R_ARCH} \
    -L$(RWINLIB)/lib${R_ARCH} 

For which R package is this?

astamm commented 2 years ago

I see, the lib folder is not organised with the usual i686, x64 and x64-ucrt folder. Why is one named lib-8.3.0? I should also add a Makevars.ucrt I suppose.

astamm commented 2 years ago

This is for a new package not yet on CRAN currently called fiberIO but soon to be riot for R inputs/outputs for tractography. These are streamlines representing brain structural information from diffusion MRI.

astamm commented 2 years ago

Also I left in PKGBUILD the pkgrel=1 line, but the version really is 9.0.1 and not 9.0.1-1, but that is detail I suppose.

jeroen commented 2 years ago

The benefit is that with this structure you don't need a Makevars.ucrt, we just use find the path based on the gcc version. If you give me the url of your package I can help to make it work.

astamm commented 2 years ago

This is the package: https://github.com/astamm/fiberIO which currently uses a configure.win which should be suppressed and a Makevars.win in which a single libvtk.a is generated but that maybe ought to change as well. Thanks!

jeroen commented 2 years ago

OK here you go: https://github.com/astamm/fiberIO/pull/4

astamm commented 2 years ago

Awesome, thanks!