r-windows / rtools-packages

Toolchains and libraries for R-4.0 to R-4.2 (legacy)
https://cran.r-project.org/bin/windows/Rtools/rtools40.html
BSD 3-Clause "New" or "Revised" License
54 stars 36 forks source link

Rebuild curl and ssh2 with the latest openssl #285

Closed kou closed 1 year ago

kou commented 1 year ago

243 upgrades OpenSSL 1 to 3. They are ABI incompatible.

Could you rebuild curl and ssh2 with the latest openssl package?

The current curl and ssh2 packages still refer OpenSSL 1 and we can't use them with OpenSSL 3. Here is an example error in apache/arrow:

https://github.com/apache/arrow/actions/runs/5569960293/jobs/10173921571?pr=36710#step:12:91

C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libcurl.a(libcurl_la-openssl.o):(.text+0x2af2): undefined reference to `EVP_PKEY_id'
C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libcurl.a(libcurl_la-openssl.o):(.text+0x53b5): undefined reference to `SSL_get_peer_certificate'
C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libcurl.a(libcurl_la-openssl.o):(.text+0x5e0a): undefined reference to `SSL_get_peer_certificate'
C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libcurl.a(libcurl_la-openssl.o):(.text+0x5fe9): undefined reference to `EVP_PKEY_id'
C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libssh2.a(crypto.o):(.text+0x3e62): undefined reference to `EVP_PKEY_id'
C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libssh2.a(crypto.o):(.text+0x5676): undefined reference to `EVP_PKEY_id'
C:\rtools42\x86_64-w64-mingw32.static.posix\bin/ld.exe: ../windows/arrow-12.0.1.9000/lib/x64-ucrt/libssh2.a(crypto.o):(.text+0x5b50): undefined reference to `EVP_PKEY_id'
jeroen commented 1 year ago

Thanks. Is thrift not affected? I guess it doesn't call any deprecated ABI.

kou commented 1 year ago

Thanks! Thrift isn't affected in our use case.