r03ert0 / microdraw

Collaborative vectorial annotation tool for ultra high resolution data.
http://microdraw.pasteur.fr
GNU General Public License v3.0
42 stars 41 forks source link

error on making 10th or more annotation #139

Closed HafezEM closed 6 years ago

HafezEM commented 6 years ago

What is the current behaviour?

On the browser/Developer tools/Console: Uncaught TypeError: Cannot read property 'classList' of null

I believe the error comes from: tag.classList.remove("deselected") when the 10th annotation is made.

Version information (for bug reports)

xgui3783 commented 6 years ago

Hi @HafezEM , Hmm, that's strange, I believe 6263d1d01fba8a789a4c7b145ad2bfef27b7624d was meant to fix the issue you described.

a quick test just now with the latest master branch, I could add more than 10 annotations:

screenshot from 2018-07-07 23-12-38

Are you able to check the latest commit of the microdraw you are running? alternatively, can you check if https://github.com/r03ert0/microdraw/blob/master/app/public/js/microdraw.js#L235 has been modified in the version you are using?

Kind regards, Xiao

HafezEM commented 6 years ago

Thank you so much Xiao. I had cloned https://github.com/neuroanatomy/microdraw because I couldn't follow some installation instructions of https://github.com/r03ert0/microdraw.

In Developer install instructions -> Basic Steps -> some instructions like github-keys.json.example -> github-keys.json, public/js/configuration.json.example -> public/js/configuration.json and server_config.json.example -> server_config.json match neuroanatomy/microdraw and not /r03ert0/microdraw.

Should I use https://github.com/r03ert0/microdraw or https://github.com/neuroanatomy/microdraw is good enough?

Regards, Hafez

xgui3783 commented 6 years ago

Hi @HafezEM , Apologies, I have made some changes in changes in microdraw, and have not yet updated the how to get started in README.md.

I will prepare a PR ASAP, but in the mean time, this is a shortened version:

git clone https://github.com/r03ert0/microdraw 
cd microdraw
npm i
cp ./app/auth/github-keys.json.example ./app/auth/github-keys.json
npm start

should start the server at port 3000 by default.

Please also note, that if you are interested in saving the annotations, you might want to specify the environment variable MONGODB. In a nutshell, replace the last line in the previous widget with something like:

MONGODB=mymongoinstance.net:27017/microdraw_db npm start

In the new PR, I will endeavour to prepare a docker-compose.yml to automate these processes.

Let us know if the above process works for you?

Kind regards, Xiao

xgui3783 commented 6 years ago

with 812472d20bd14e3740aa9227630ebe2066ac6bd7 the readme should be updated and docker-compose.yml included

HafezEM commented 6 years ago

Hi @xgui3783,

Thank you so much for your reply. That worked. The only thing I had to change was to create symbolic link for openseadragon, openseadragon-screenshot and FileSaver.js in /app/public/lib folder. You might need to take that into consideration.

Regards, Hafez

xgui3783 commented 6 years ago

closed via a8646235f4010d85c85d20397fc82a8462592a0a