search

r0adkll / sign-android-release

A GitHub action to sign an APK or AAB
MIT License
362 stars 137 forks source link

Add the ability to sign multiple APKs #13

Open Abushawish opened 4 years ago

Abushawish commented 4 years ago

Currently, this Action will only sign the first APK it finds in the release directory. However, occasionally a release will have multiple APKs (for example, different build variants or different architectures). Is it possible for this Action to sign multiple APKs at once?

r0adkll commented 4 years ago

That shouldn't be too difficult to add

Abushawish commented 4 years ago

I submitted a PR with this enhancement if you're interested: https://github.com/r0adkll/sign-android-release/pull/14

r0adkll commented 4 years ago

Bump. I have requested changes to the PR for your request. I've you can apply them I'll happily merge them in.

tiann commented 3 years ago

Any updates?

victorpaleologue commented 3 years ago

The PR was never completed. I had a look and boldly tried to complete it: https://github.com/r0adkll/sign-android-release/pull/49 I hope it will get accepted.

Abushawish commented 3 years ago

Sorry all, life got in the way and my issue/PR has become stale. Please look into Victor's PR https://github.com/r0adkll/sign-android-release/pull/49 :).