search

r0adkll / sign-android-release

A GitHub action to sign an APK or AAB
MIT License
362 stars 137 forks source link

Support signing multiple release files + address review comments #20

Closed abhijitvalluri closed 3 years ago

abhijitvalluri commented 4 years ago

Addresses issue 13 to support signing multiple APKs: #13

Also, addresses the review comments in the stale PR #14.

Regarding https://github.com/r0adkll/sign-android-release/pull/14#discussion_r463029841, I am not familiar with Github Actions but I could not figure out how to set variable number of outputs in the actions.yml file. Your suggestion will require some variable number of outputs and also the outputs change depending on situation, i.e. if there is just one apk file to sign, the output is signedReleaseFile, otherwise it is of the format signedReleaseFile0...signedReleaseFile{n}. So, I made the output a comma delimited string.

r0adkll commented 3 years ago

Closing with https://github.com/r0adkll/sign-android-release/pull/49 merged