r0adkll / sign-android-release

A GitHub action to sign an APK or AAB
MIT License
362 stars 137 forks source link

Fix zipalign for Android Gradle Plugin 4.1.0 #24

Closed jobobby04 closed 4 years ago

jobobby04 commented 4 years ago

The Android Gradle Plugin v4.1.0 outputs aligned APKs, so we just do a zipalign check rather than actually trying to align it. Linked issue https://issuetracker.google.com/issues/162117652

thomastvedt commented 4 years ago

I forked and tested this, and it works as expected. Would be great if this PR could be merged, current version doesn't work at all 👍🏼

davwheat commented 4 years ago

@r0adkll Can we get this merged, please?

r0adkll commented 4 years ago

Sorry about the delay on this! I have merged it and should be available on @v1

davwheat commented 4 years ago

Woohoo! Thank you! :)