search

r0adkll / sign-android-release

A GitHub action to sign an APK or AAB
MIT License
362 stars 137 forks source link

Build is not signing #52

Open rubverma opened 3 years ago

rubverma commented 3 years ago

My android build signing is failing now. Below is the debug log

Preparing to sign key @ bin/Debug with signing key Found 2 release files.

Verifying alignment of bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed.apk (4)...

Verification succesful
---
/bin/cp bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed.apk bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-aligned.apk
/Users/runner/Library/Android/sdk/build-tools/29.0.3/apksigner sign --ks bin/Debug/signingKey.jks --ks-key-alias *** --ks-pass pass:*** --out bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-signed.apk --key-pass pass:*** bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-aligned.apk
/Users/runner/Library/Android/sdk/build-tools/29.0.3/apksigner verify bin/Debug/com.vermaru.xamarinandroidcicddemo-Signed-signed.apk
/Users/runner/Library/Android/sdk/build-tools/29.0.3/zipalign -c -v 4 bin/Debug/com.vermaru.xamarinandroidcicddemo.apk
Verifying alignment of bin/Debug/com.vermaru.xamarinandroidcicddemo.apk (4)...
---
Verification FAILED
Error: The process '/Users/runner/Library/Android/sdk/build-tools/29.0.3/zipalign' failed with exit code 1

Ideally It should do verification for non signed apk files i.e. com.vermaru.xamarinandroidcicddemo.apk

The same was working fine till 3days back. I guess this is happening due to https://github.com/r0adkll/sign-android-release/pull/49

Note: - I'm creating single apk.

rubverma commented 3 years ago

@r0adkll , Please have a look in this. I'm block currently due to this issue. Let me know if any other information needed.

Thanks

r0adkll commented 3 years ago

Hmmm, you could try overriding the build tools version in your yaml configuration, so something like:

README.md

env:
      # override default build-tools version (29.0.3) -- optional
      BUILD_TOOLS_VERSION: "30.0.2"

or you could try pointing this task to the old version via @v1.0.4

rubverma commented 3 years ago

Thank you @r0adkll for quick response.

I tried overriding build tools version in yaml configuration but that didn't work. Time being i'm pointing it to 36fdfa1361ee106737f5bd9004298b08e7055dc4 to unblocking my team.

jemshit commented 2 years ago

So why this happens? Trying to sign already-signed apk?

tanifort commented 2 years ago

Just ran into the same issue and I can't seem to figure out why it is happening. I have tried all proposed solutions, but nothing is working for me.