search

r0gue-io / base-parachain

A standard parachain template, used as the base for other templates.
The Unlicense
3 stars 6 forks source link

fix: Revert relay number check #25

Closed al3mart closed 3 months ago

al3mart commented 3 months ago

It seems that we included a regression.

We configured CheckAssociatedRelayNumber = RelayNumberStrictlyIncreases while using the lookahead collator:

This changed combined with the fact that you are using the lookahead collator and async backing, you run into this error message. The lookahead collator is building multiple parachain blocks on the same relay chain block. This leads to this issue, as the relay chain number is not strictly increasing between parachain blocks. Reverting this change will fix it.

I considered introducing a test for this, so we can verify such a regression is not included in future changes. But being the "base-parachain" and the one we are using to maintain the rest of our templates now and generate them in the future, that felt like maybe too much of an opinion to make.

al3mart commented 3 months ago

This unlocks #23

al3mart commented 3 months ago

Awesome, thanks for the quick approval