r0gue-io / base-parachain

A standard parachain template, used as the base for other templates.
The Unlicense
3 stars 6 forks source link

chore: new pallet #32

Open Daanvdplas opened 4 months ago

Daanvdplas commented 4 months ago

This functionality already exists and is great for devs to kickstart the development. It creates a pallets folder with a fresh pallet folder ready to build.

Showing that it exists can also get early user feedback.

brunopgalvao commented 4 months ago

I like the idea! I would add a phrase before that to download/install Pop CLI (with a link)

Also, the running your parachain link in the README should be:

Daanvdplas commented 4 months ago

The link for "Learn about how to build using this template" was the best tutorial I could find for someone that needs info about how to start building their first pallet. I think we want something like that on the pop website, maybe trying to find the kitties example and update it.

AlexD10S commented 4 months ago

I'd prefer to point a link to our documentation instead of: https://subdaily.io/dev/learn-to-build-substrate-pallets-from-scratch-dissecting-the-frame-pallet/ This way, we can maintain it.

The line: 👷 Start with building a new pallet is a great idea. However, as with the previous point, can we create a tutorial in our documentation and link to it instead of adding basic code? This approach will be more consistent with the rest of the points.

pop new pallet <pallet_name>
brunopgalvao commented 4 months ago

Okay. We need to define exactly what we want to add to the Pop Docs. Do we want a section called "Add a pallet to a parachain" that highlights the pop new pallet <pallet_name> command? Or do we want something more comprehensive?

https://subdaily.io/dev/learn-to-build-substrate-pallets-from-scratch-dissecting-the-frame-pallet/

brunopgalvao commented 4 months ago

Based on @kianenigma's comment here: https://github.com/r0gue-io/pop-cli/issues/260 I would like to point to Polkadot SDK Docs (or Pop Docs) as much as possible. e.g. https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/guides/your_first_pallet

Also: https://paritytech.github.io/polkadot-sdk/master/polkadot_sdk_docs/polkadot_sdk/frame_runtime

Daanvdplas commented 2 months ago

@brunopgalvao can you decide whether to use this or otherwise close this draft please