search

r0gue-io / base-parachain

A standard parachain template, used as the base for other templates.
The Unlicense
3 stars 6 forks source link

feat: add linkchecker to CI #33

Open brunopgalvao opened 3 months ago

brunopgalvao commented 3 months ago

This PR adds the Linkspector to the CI on Pull Requests.

Daanvdplas commented 2 months ago

If you want reviews on this you should ask for it :)

brunopgalvao commented 2 months ago

If you want reviews on this you should ask for it :)

Thanks for the reminder, will follow up with this once I finish the Pop presentation this week.

brunopgalvao commented 2 months ago

has this been tested? If not, adding a simple manual trigger would do the trick.

Tested here: https://github.com/brunopgalvao/base-parachain/pull/2

peterwht commented 2 months ago

has this been tested? If not, adding a simple manual trigger would do the trick.

Tested here: brunopgalvao#2

amazing!

brunopgalvao commented 2 months ago

For good security practices, can we have a custom GitHub token with limited access created for this a linkspector action? I do not have permissions to manage/create tokens.

Daanvdplas commented 1 month ago

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

brunopgalvao commented 1 month ago

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

Once we have

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

Looking into this: https://github.com/UmbrellaDocs/action-linkspector/issues/20

brunopgalvao commented 1 month ago

Would it be possible to have this working on all the links in the repo, not only the links in the PR?

🪄

Done. Please approve & merge.