Closed AlexD10S closed 5 days ago
Attention: Patch coverage is 57.98817%
with 71 lines
in your changes missing coverage. Please review.
Project coverage is 69.86%. Comparing base (
e95c42b
) to head (a85a974
).
@@ Coverage Diff @@
## main #203 +/- ##
==========================================
+ Coverage 68.55% 69.86% +1.30%
==========================================
Files 44 44
Lines 6374 6558 +184
Branches 6374 6558 +184
==========================================
+ Hits 4370 4582 +212
+ Misses 1337 1251 -86
- Partials 667 725 +58
Files | Coverage Δ | |
---|---|---|
crates/pop-contracts/src/errors.rs | 0.00% <ø> (ø) |
|
crates/pop-cli/src/commands/up/contract.rs | 0.00% <0.00%> (ø) |
|
crates/pop-contracts/src/up.rs | 63.80% <75.00%> (+63.80%) |
:arrow_up: |
crates/pop-cli/src/commands/call/contract.rs | 0.00% <0.00%> (ø) |
|
crates/pop-contracts/src/call.rs | 69.84% <67.08%> (+69.84%) |
:arrow_up: |
Integration tests are required to test the call and up contracts, but is our of scope of this PR.
Can an issue be created for this.
For
pop up contract
andpop call contract
adds a new flag--dry-run
to perform a dry-run via RPC to estimate the gas usage without submitting a transaction.Closes https://github.com/r0gue-io/pop-cli/issues/134
This PR also corrects some inaccurate error messages and refactors these errors to use the
thiserror
crate in thepop_contracts
module. This refactor continues the work initiated in the previous PR: https://github.com/r0gue-io/pop-cli/pull/111 Integration tests are required to test thecall
andup
contracts, but is our of scope of this PR.