search

r0gue-io / pop-cli

An all-in-one tool for Polkadot development.
GNU General Public License v3.0
74 stars 21 forks source link

refactor(contracts): default to riscv release build #324

Closed evilrobot-01 closed 3 weeks ago

evilrobot-01 commented 1 month ago

Should enable riscv contract building.

Note that I have not been able to test due to struggling to get the rve-nightly toolchain installed on my system.

AlexD10S commented 3 weeks ago

The build works with this change. However to make the branch useful, we need to update the pop new contract feature to generate the contract with the following:

ink = { git = "https://github.com/r0gue-io/ink ", branch = "sub0", default-features = false }
polkavm-derive = "0.11.0"

The e2e test contract_lifecycle is failing because of that.

Resolved the issue with a change in cargo-contract. It can be merged now. To fix the contract_lifecycle test we will need to update substrate-contracts-node to use pallet_revive (not for now).