search

r0man / cljs-http

A ClojureScript HTTP library.
582 stars 93 forks source link

Unit test failing #114

Closed jmlsf closed 6 years ago

jmlsf commented 6 years ago

@r0man The unit tests are failing as we discussed. It appears to be because of phantomjs. This fix looks a bit ugly. See this issue:

https://github.com/bensu/doo/issues/140

I tried it with karma & chrome-headless and the tests pass. I'll submit a PR if you want to try it out.

r0man commented 6 years ago

@jmlsf Yes, a PR would be welcome. We can also drop phantom if there are better options?

jmlsf commented 6 years ago

If we can get chrome-headless to work in travis, that is surely better. The problem here is that I need to install karma to use chrome-headless with lein-doo. I think I'll have to add a package.json to do so.

jmlsf commented 6 years ago

Okay I got it to work. I'm don't have a lot of expertise, but the general sentiment seems to be that using chrome is better then using phantom. Seems logical that using a real browser is better than a mock.