search

r0man / sablono

Lisp/Hiccup style templating for Facebook's React in ClojureScript.
Eclipse Public License 1.0
694 stars 66 forks source link

:npm-deps compat #176

Closed lgrapenthin closed 5 years ago

lgrapenthin commented 7 years ago

If I require per :npm-deps Compiler feater, is there already a way to use Sablono? Right now Sablono says No such namespace: cljsjs.react, could not locate cljsjs/react.cljs, cljsjs/react.cljc, or JavaScript source providing "cljsjs.react", in resources/public/cljs/out/sablono/interpreter.cljc

r0man commented 7 years ago

@lgrapenthin I haven't looked at the new :npm-deps stuff yet, and quite busy at the moment and don't have time to look into this now. @Deraen opened a PR recently but I'm not sure of it's state. https://github.com/r0man/sablono/pull/175

Deraen commented 7 years ago

I will try to fix the tests with the changes soon. Releasing the support will require updating also Om, Rum and Devcards at the same time as Sablono.

Btw. :npm-deps is not a correct name for the new features. "Node modules support" or "Module processing" are better names. I'll try to update ClojureScript docs before we update all the packages.

r0man commented 7 years ago

@Deraen ok, thanks for the update and the work on the PR.

r0man commented 5 years ago

Closing this. Latest master requires React now, instead of using js/React