Start adding support for React's Fragment : almost there !

r0man / sablono

Lisp/Hiccup style templating for Facebook's React in ClojureScript.

Eclipse Public License 1.0

696 stars 66 forks source link

Start adding support for React's Fragment : almost there ! #182

Closed DjebbZ closed 6 years ago

DjebbZ commented 6 years ago

Hi, I've started working on Rect's Fragment support for Sablono, so that you can publish a version of sablono that we can try to integrate into rum.

Somes notes :

I've arbitrarily decided to use the :* syntax for Fragment (i.e. [:* [:div] [:div]]). Feel free to choose something else.
I've written 4 tests, only 1 fail. I've double-checked in the online Babeljs repl that the syntax matches what calls to equivalent JSX would be. The failing test relies on some implementation details of Sablono (the divide between the compiler and the interpreter) that I don't really understand. Could have a look ?

I think we're pretty close to fully suppot React 16 with this. I'd love if you could continue this effort, as my understanding of Sablono is limited here.

DjebbZ commented 6 years ago

Beh, 1 fail on my machine, 2 on Travis. No idea what's happening.

DjebbZ commented 6 years ago

Bumping. Did you try the branch ? What's your plan regarding React's Fragment ?

r0man commented 6 years ago

@DjebbZ No, sorry I haven't looked into this yet. I'm fine with using ":*" for fragments. I think other react wrappers use the same. I think to move this forward, we would also need server side rednering support for this.

DjebbZ commented 6 years ago

I may try to have a look into it sometime this week.

nha commented 6 years ago

The failing test relies on some implementation details of Sablono (the divide between the compiler and the interpreter) that I don't really understand.

From what I remember this is the number one problem when trying to contribute to sablono (which is great to use btw 👍 ). Maybe a small section in the README or a CONTRIBUTING.md explaining the idea between the divide would help new contributors?

DjebbZ commented 6 years ago

In the README it would be perfect.

Le 22 janv. 2018 19:04, "Nicolas Ha" notifications@github.com a écrit :

The failing test relies on some implementation details of Sablono (the divide between the compiler and the interpreter) that I don't really understand.

From what I remember this is the number one problem when trying to contribute to sablono (which is great to use btw 👍 ). Maybe a small section in the README or a CONTRIBUTING.md explaining the idea between the divide would help new contributors?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/r0man/sablono/pull/182#issuecomment-359511588, or mute the thread https://github.com/notifications/unsubscribe-auth/AAEt3msGIep5DZ0U9ztzfGCZ3LzuKSsMks5tNM2SgaJpZM4RPNWt .

r0man commented 6 years ago

Closing this, since it's merged into https://github.com/r0man/sablono/pull/181 Thanks!