Closed zlorf closed 6 years ago
@zlorf Sure, PR with some tests welcome!
No attribution required. I think some of them also came from others from a gist.
@r0man I'll prepare PR and tests. But I've just found that test-element-meta
is broken (no expected
in the are
macro, and even after adding it the test fails).
I'm invoking the tests via lein ci
.
@zlorf Yes, you are right. I fix it over here: https://github.com/r0man/sablono/pull/185
Excellent, thanks!
@zlorf I added a couple of more forms from @rauhs (thanks!) hicada's allgäu ;)
@r0man Thanks! I was considering to try refactor my approach to invoke clojurescript macro compiler (no time, though). But, well, enumerating all forms is still a solution. :)
The compiler "walks" properly on some forms, but not on others:
I think that some popular forms are missing here. @rauhs has included a more comprehensive list: https://github.com/rauhs/hicada/blob/master/src/hicada/compiler.clj#L159
Maybe we can move those multimethods, with the proper author attribution?