r0man / soundklaus.el

Play music on SoundCloud with Emacs via EMMS
GNU General Public License v3.0
42 stars 5 forks source link

Use cl-lib instead of cl.el #1

Closed syohex closed 10 years ago

syohex commented 10 years ago

There are both cl-lib a function(cl-mapcan) and cl.el a function(gensym), macros(loop) in original code. And you should not use eval-when-compile because this code uses cl-lib function(gensym).

r0man commented 10 years ago

Hi syohex,

thanks for your pull request. I merged it. Can you recommend anything where I can read up about these kind of issues. E.g. what's the state of the art in Elisp development?

Thanks, Roman

syohex commented 10 years ago

And I recommend you to byte-compile your package files. To byte-compile tells you

etc.