search

r0oth3x49 / acloud-dl

A cross-platform python based utility to download courses from acloud.guru for personal offline use.
MIT License
351 stars 142 forks source link

Add "optionally download quizzes" feature #76

Closed esidate closed 2 years ago

esidate commented 3 years ago

Adding -z or --quizzes flag will download quizzes too. Quizzes are downloaded in JSON format. We can later add a script to parse those JSON files and give the user an interactive GUI using PyInquirer and Click.

r0oth3x49 commented 3 years ago

@thehunckerma do you think downloading quizzes is good?

esidate commented 3 years ago

Hello @r0oth3x49 I'm not sure what do you mean by good but in my case i needed to have the quizzes too, to test my knowledge obviously. I was willing to write the code for it anyways, i just thought it would be cool to make a pull request out of it. After all it's an optional feature, merging it wouldn't do any harm and it's been tested on 145 courses (by myself).

esidate commented 2 years ago

Hello @r0oth3x49 will you merge this anytime soon ?

r0oth3x49 commented 2 years ago

@esidate sorry for the very late response would be great if you can fix the conflicts and make another pull request so that i can merge it.

esidate commented 2 years ago

@r0oth3x49 Hello, my pull request was pending for 4 months and now i have to merge it with a 5 days old pull request. That's unfortunate.

ibrahimjelliti commented 2 years ago

@esidate I pulled your PR, the quiz data is not downloaded. I always got the content array empty in the quiz JSON file

esidate commented 2 years ago

Hello @ibrahimjelliti that's because another pull request that was made 4 months after mine and was merged first.