search

r0oth3x49 / lynda-dl

A cross-platform python based utility to download courses from lynda.com for personal offline use.
MIT License
295 stars 95 forks source link

Would you add download subtitle feauture ? #2

Closed webeasyplay closed 6 years ago

webeasyplay commented 6 years ago

Would you add download subtitle feauture ?

r0oth3x49 commented 6 years ago

@webeasyplay thanks for the suggestion another friend of mine on Facebook also suggested me to add the this feature. you can download subtitles only as well by using (--sub-only or -s) option which will skip videos and download the subtitles only, by default it will download the videos and subtitles both.

webeasyplay commented 6 years ago

It's work! But the srt and video filename are not same. When I open video player to play the video. It's not autoload the srt file. image

r0oth3x49 commented 6 years ago

@webeasyplay which video player you are using? there is no option to add subtitle for a video?

webeasyplay commented 6 years ago

PotPlayer! If filename are same! It's autoload srt file perfect

r0oth3x49 commented 6 years ago

@webeasyplay can you check again and let me know if still the problem occurs. POC of same name: untitled

webeasyplay commented 6 years ago

I try it again. The srt file and video filename must be same! Examle: 001-Welcome.mp4 001-Welcome.srt

In fact 001 Welcome.mp4 001-Welcome.srt

r0oth3x49 commented 6 years ago

@webeasyplay clone the updated repo then try see the above Screenshot of same name. have a look. capture

webeasyplay commented 6 years ago

It's work now ! Thank you