smaller fixes / changes

r0oth3x49 / udemy-dl

A cross-platform python based utility to download courses from udemy for personal offline use.

MIT License

4.86k stars 1.2k forks source link

smaller fixes / changes #459

Closed Nightreaver closed 4 years ago

Nightreaver commented 4 years ago

slugify to replace "&" with "and" before cleaning up:
Tips & Tricks will now become Tips and Tricks and not just Tips Tricks

slugify to replace double-space with single-space after cleaning: sometimes after replacing a symbol/char between words, text might be like Tips Tricks as only the symbol is remove, now remove double space in case it happens again (not with & at least)

change to avoid calling _extract_subtitles() / _extract_sources() multiple times

r0oth3x49 commented 4 years ago

These are not http calls so does it affect some sort of functionality and i don't think so changing & to and is good idea material should be same as it is retrieved. Thanks for the PR any way, i have all these in plan for next version code will be a lot cleaner then it is now.