r0oth3x49 / udemy-dl

A cross-platform python based utility to download courses from udemy for personal offline use.
MIT License
4.86k stars 1.2k forks source link

Cannot read property 'split' #476

Closed Melgan closed 4 years ago

Melgan commented 4 years ago

Describe the bug A clear and concise description of what the bug is. Also on system, where it work before fine

When try to download video there is an error. Tested on Ubuntu, debian, aarch arm.

Tested on latest UDL 2.(something) and 1

To Reproduce Steps to reproduce the behavior:

  1. udemy course url: [e.g https://www.udemy.com/machinelearning/] '...' tested few different
  2. Run the following command to reproduce the error.
  3. See error ? Enter your password: ** ? Select a course to download: 1 ) Docker Mastery: with Kubernetes +Swarm from a Docker Captain ? Select the maximum video resolution to download: 720 ◞ Initializing, please wait... /usr/local/lib/node_modules/udemy-dl/lib/core.js:619 var file = query_obj.filename.split('.'); ^

TypeError: Cannot read property 'split' of undefined at Request._callback (/usr/local/lib/node_modules/udemy-dl/lib/core.js:619:51) at Request.self.callback (/usr/local/lib/node_modules/udemy-dl/node_modules/request/request.js:185:22) at emitTwo (events.js:126:13) at Request.emit (events.js:214:7) at Request. (/usr/local/lib/node_modules/udemy-dl/node_modules/request/request.js:1161:10) at emitOne (events.js:116:13) at Request.emit (events.js:211:7) at IncomingMessage. (/usr/local/lib/node_modules/udemy-dl/node_modules/request/request.js:1083:12) at Object.onceWrapper (events.js:313:30) at emitNone (events.js:111:20)

Expected behavior A clear and concise description of what you expected to happen. dowloaded video

Screenshots If applicable, add screenshots to help explain your problem.

Python Environment (please complete the following information):

Additional context Add any other context about the problem here.