r0oth3x49 / udemy-dl

A cross-platform python based utility to download courses from udemy for personal offline use.
MIT License
4.83k stars 1.19k forks source link

Script crashes on large course. #538

Closed bfriendjr closed 3 years ago

bfriendjr commented 3 years ago

Describe the bug

I am getting the following error on only one of my courses. It almost seems as if its timing out when its getting the initial course info. I have over 100 courses and this is the only giving me issues

It has 36 sections and 573 videos and documents https://www.udemy.com/course/ios-13-app-development-bootcamp/

Command python udemy-dl.py https://www.udemy.com/course/ios-13-app-development-bootcamp/ -o "/Volumes/WDPP5T01B/Multimedia/Video Courses/Udemy Courses/20180828 - iOS 13 - Swift 5 - The Complete iOS App Development Bootcamp/" -k udemycookie.txt -q 720

Error Message [] : Trying to login using cookies ... [+] : Logged in successfully. Traceback (most recent call last):on .. File "udemy-dl.py", line 1453, in main() File "udemy-dl.py", line 974, in main udemy.course_save(path=options.output, quality=options.quality, caption_only=options.caption_only, skip_captions=options.skip_captions, names_only=options.names_only, unsafe=options.unsafe) File "udemy-dl.py", line 65, in course_save course = udemy.course(url=self.url, username=self.username, password=self.password, cookies=self.cookies) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_udemy.py", line 38, in course return Udemy(url, username, password, cookies, basic, callback) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_internal.py", line 44, in init super(InternUdemyCourse, self).init(args, kwargs) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_shared.py", line 258, in init self._fetch_course() File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_internal.py", line 56, in _fetch_course self._info = self._real_extract(self._url) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 449, in _real_extract course_json = self._extract_course_json(url, course_id, portal_name) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 250, in _extract_course_json resp = self._extract_large_course_content(url=url) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 223, in _extract_large_course_content resp = self._session._get(_next).json() File "/Users/williamfriend/Library/Python/2.7/lib/python/site-packages/requests/models.py", line 898, in json return complexjson.loads(self.text, kwargs) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/init.py", line 339, in loads return _default_decoder.decode(s) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 364, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 382, in raw_decode raise ValueError("No JSON object could be decoded") ValueError: No JSON object could be decoded

System Info MacOS Catalina 10.15.6

bfriendjr commented 3 years ago

Thanks for the quick response, unfortunately I can not share my credentials. So please close the ticket if you can not investigate further.

What is the best way to make a donation?

On Jul 24, 2020, at 9:53 PM, kumarnipun notifications@github.com wrote:

Please share me your credentials. I can try to download.

On Sat, 25 Jul 2020 at 8:07 AM, William D. Friend Jr. < notifications@github.com> wrote:

Describe the bug

I am getting the following error on only one of my courses. It almost seems as if its timing out when its getting the initial course info. I have over 100 courses and this is the only giving me issues

It has 36 sections and 573 videos and documents https://www.udemy.com/course/ios-13-app-development-bootcamp/

Command python udemy-dl.py https://www.udemy.com/course/ios-13-app-development-bootcamp/ -o "/Volumes/WDPP5T01B/Multimedia/Video Courses/Udemy Courses/20180828 - iOS 13 - Swift 5 - The Complete iOS App Development Bootcamp/" -k udemycookie.txt -q 720

Error Message [] : Trying to login using cookies ... [+] : Logged in successfully. Traceback (most recent call last):on .. File "udemy-dl.py", line 1453, in main() File "udemy-dl.py", line 974, in main udemy.course_save(path=options.output, quality=options.quality, caption_only=options.caption_only, skip_captions=options.skip_captions, names_only=options.names_only, unsafe=options.unsafe) File "udemy-dl.py", line 65, in course_save course = udemy.course(url=self.url, username=self.username, password=self.password, cookies=self.cookies) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_udemy.py", line 38, in course return Udemy(url, username, password, cookies, basic, callback) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_internal.py", line 44, in init super(InternUdemyCourse, self).init(args, kwargs) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_shared.py", line 258, in init self._fetch_course() File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_internal.py", line 56, in _fetch_course self._info = self._real_extract(self._url) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 449, in _real_extract course_json = self._extract_course_json(url, course_id, portal_name) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 250, in _extract_course_json resp = self._extract_large_course_content(url=url) File "/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 223, in _extract_large_course_content resp = self._session._get(_next).json() File "/Users/williamfriend/Library/Python/2.7/lib/python/site-packages/requests/models.py", line 898, in json return complexjson.loads(self.text, kwargs) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/ init.py", line 339, in loads return _default_decoder.decode(s) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 364, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 382, in raw_decode raise ValueError("No JSON object could be decoded") ValueError: No JSON object could be decoded

System Info MacOS Catalina 10.15.6

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/r0oth3x49/udemy-dl/issues/538, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF33XP2LA2DQBUYFZNWSSDDR5JAPZANCNFSM4PHHLSCA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/r0oth3x49/udemy-dl/issues/538#issuecomment-663798289, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYU63UB53RNPWDV72CG22DR5JCKFANCNFSM4PHHLSCA.

bfriendjr commented 3 years ago

I use cellular hotspots for my internet. I just switched to a faster one with 80 mbps download and its working now. The script must time out too quickly.

Thanks for the assistance.

On Jul 24, 2020, at 10:02 PM, kumarnipun notifications@github.com wrote:

I can download it for u and share it with you

On Sat, 25 Jul 2020 at 8:30 AM, William D. Friend Jr. < notifications@github.com> wrote:

Thanks for the quick response, unfortunately I can not share my credentials. So please close the ticket if you can not investigate further.

What is the best way to make a donation?

On Jul 24, 2020, at 9:53 PM, kumarnipun notifications@github.com wrote:

Please share me your credentials. I can try to download.

On Sat, 25 Jul 2020 at 8:07 AM, William D. Friend Jr. < notifications@github.com> wrote:

Describe the bug

I am getting the following error on only one of my courses. It almost seems as if its timing out when its getting the initial course info. I have over 100 courses and this is the only giving me issues

It has 36 sections and 573 videos and documents https://www.udemy.com/course/ios-13-app-development-bootcamp/

Command python udemy-dl.py https://www.udemy.com/course/ios-13-app-development-bootcamp/ -o "/Volumes/WDPP5T01B/Multimedia/Video Courses/Udemy Courses/20180828 - iOS 13 - Swift 5 - The Complete iOS App Development Bootcamp/" -k udemycookie.txt -q 720

Error Message [*] : Trying to login using cookies ... [+] : Logged in successfully. Traceback (most recent call last):on .. File "udemy-dl.py", line 1453, in main() File "udemy-dl.py", line 974, in main udemy.course_save(path=options.output, quality=options.quality, caption_only=options.caption_only, skip_captions=options.skip_captions, names_only=options.names_only, unsafe=options.unsafe) File "udemy-dl.py", line 65, in course_save course = udemy.course(url=self.url, username=self.username, password=self.password, cookies=self.cookies) File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_udemy.py", line 38, in course return Udemy(url, username, password, cookies, basic, callback) File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_internal.py", line 44, in init super(InternUdemyCourse, self).init(*args, **kwargs) File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_shared.py", line 258, in init self._fetch_course() File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_internal.py", line 56, in _fetch_course self._info = self._real_extract(self._url) File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 449, in _real_extract course_json = self._extract_course_json(url, course_id, portal_name) File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 250, in _extract_course_json resp = self._extract_large_course_content(url=url) File

"/Volumes/WDPP5T01A/Development/Python/udemy-dl-master/udemy/_extract.py", line 223, in _extract_large_course_content resp = self._session._get(_next).json() File

"/Users/williamfriend/Library/Python/2.7/lib/python/site-packages/requests/models.py", line 898, in json return complexjson.loads(self.text, **kwargs) File

"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/ init.py", line 339, in loads return _default_decoder.decode(s) File

"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 364, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File

"/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/json/decoder.py", line 382, in raw_decode raise ValueError("No JSON object could be decoded") ValueError: No JSON object could be decoded

System Info MacOS Catalina 10.15.6

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/r0oth3x49/udemy-dl/issues/538, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AF33XP2LA2DQBUYFZNWSSDDR5JAPZANCNFSM4PHHLSCA

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/r0oth3x49/udemy-dl/issues/538#issuecomment-663798289>, or unsubscribe < https://github.com/notifications/unsubscribe-auth/AFYU63UB53RNPWDV72CG22DR5JCKFANCNFSM4PHHLSCA .

— You are receiving this because you commented.

Reply to this email directly, view it on GitHub https://github.com/r0oth3x49/udemy-dl/issues/538#issuecomment-663798967, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF33XP4NWXIWMA7RD7UTJTLR5JDFVANCNFSM4PHHLSCA .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/r0oth3x49/udemy-dl/issues/538#issuecomment-663799108, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFYU63XGLYCWDVW6IA723OTR5JDKTANCNFSM4PHHLSCA.

xd003 commented 3 years ago

@bfriendjr you may close the issue if its fixed or tag the creator of this repository if you want to suggest something regarding the timeout on slow internet connections. I think you were mistaknely assuming a different person as the creator of this repo

r0oth3x49 commented 3 years ago

@bfriendjr you may close the issue if its fixed or tag the creator of this repository if you want to suggest something regarding the timeout on slow internet connections. I think you were mistaknely assuming a different person as the creator of this repo

thanks man, i have reported this to github and also added an important note in readme file so that everyone knows when the credentials are required.

r0oth3x49 commented 3 years ago

@bfriendjr thanks man i really appreciate your donation you can or donate or become a sponsor or just enjoy using the tool. you can email me if you feel like this tool help you and want to make donations., i 'm using TransferWise to accept donations. my email is: nasir251292@gmail.com

davidhenley commented 3 years ago

Why is this closed? How can we fix?