klerpi
commented
4 years ago Look at the commit diff. I only changed the "download" word. Unless the README text is tied to the code somehow I can't see why the PR is the one breaking it.
If you're asking me generally if the program is working on my computer, the answer is yes. Make sure you've installed all the dependencies properly. If you're still facing problems after that open an issue. Best of luck!
klerpi .. is the code working for you ? cause for me its not. here is the error
File "/content/udemy-dl/udemy-dl.py", line 611, in <module> main() File "/content/udemy-dl/udemy-dl.py", line 595, in main skip_hls_stream=args.skip_hls_stream, File "/content/udemy-dl/udemy-dl.py", line 288, in course_download skip_hls_stream=skip_hls_stream, File "/content/udemy-dl/udemy/udemy.py", line 40, in course return Udemy(url, username, password, cookies, basic, skip_hls_stream, callback) File "/content/udemy-dl/udemy/internal.py", line 65, in __init__ super(InternUdemyCourse, self).__init__(*args, **kwargs) File "/content/udemy-dl/udemy/shared.py", line 300, in __init__ self._fetch_course() File "/content/udemy-dl/udemy/internal.py", line 78, in _fetch_course self._info = self._real_extract(self._url, skip_hls_stream=self._skip_hls_stream) File "/content/udemy-dl/udemy/extract.py", line 608, in _real_extract course_json = self._extract_course_json(url, course_id, portal_name) File "/content/udemy-dl/udemy/extract.py", line 347, in _extract_course_json resp = self._extract_large_course_content(url=url) File "/content/udemy-dl/udemy/extract.py", line 311, in _extract_large_course_content data = self._session._get(url).json() File "/usr/local/lib/python3.6/dist-packages/requests/models.py", line 898, in json return complexjson.loads(self.text, **kwargs) File "/usr/lib/python3.6/json/__init__.py", line 354, in loads return _default_decoder.decode(s) File "/usr/lib/python3.6/json/decoder.py", line 339, in decode obj, end = self.raw_decode(s, idx=_w(s, 0).end()) File "/usr/lib/python3.6/json/decoder.py", line 357, in raw_decode raise JSONDecodeError("Expecting value", s, err.value) from None json.decoder.JSONDecodeError: Expecting value: line 1 column 1 (char 0)