search

r0wbrt / advertsieve

Transparent proxy server for content policy management
Other
1 stars 0 forks source link

HTTP Client has long timeouts #10

Closed r0wbrt closed 6 years ago

r0wbrt commented 6 years ago

The http client in use can timeout the server for a site if all of the keep alive connections in the pool are allocated and waiting for a response from the remote server. The fix for this is to add timeouts and other guards to make the http client more robust.

This is also a security issue since it could be used to construct a DOS attack.

r0wbrt commented 6 years ago

On further investigation reveals it to be related to a network change event. Eg, switching wifi networks. So it likely is a TCP timeout issue. Regular connect continues to work since it creates new TCP connections per method invocation. The client on the other hand reuses existing TCP sockets.

r0wbrt commented 6 years ago

Should have been fixed by 467599511d4afb634e00beaad0eb47d3031d2665