r0wbrt / advertsieve

Transparent proxy server for content policy management
Other
1 stars 0 forks source link

Do not log header timeout #25

Open r0wbrt opened 6 years ago

r0wbrt commented 6 years ago

Should not log the error generated by a header timeout. The error message is not novel nor actionable. Only useful for debugging.

r0wbrt commented 6 years ago

74a70964be6c7bcce71cdfd9fa517d3e5d9557b0

r0wbrt commented 6 years ago

Seems like it is still happening

r0wbrt commented 6 years ago

2018/01/05 14:39:27 Starting advertsieve version 18.01.01 unstable. 2018/01/05 14:39:27 Program advertsieve started with arguments: "config" 2018/01/05 14:39:27 Using configuration file: config 2018/01/05 14:50:16 lookup cafelinux.org on 127.0.0.53:53: server misbehaving 2018/01/05 15:54:37 net/http: timeout awaiting response headers 2018/01/05 15:58:46 dial tcp 74.113.233.66:80: getsockopt: connection timed out

r0wbrt commented 6 years ago

6251fe13102688f61165dc03a75826936a096db0

r0wbrt commented 6 years ago

Still happening:

2018/01/14 16:57:38 net/http: timeout awaiting response headers
2018/01/14 16:58:12 net/http: timeout awaiting response headers
2018/01/14 16:58:48 net/http: timeout awaiting response headers
2018/01/14 16:59:27 net/http: timeout awaiting response headers
2018/01/14 17:00:15 net/http: timeout awaiting response headers
2018/01/14 17:01:17 net/http: timeout awaiting response headers
2018/01/14 17:02:19 net/http: timeout awaiting response headers
2018/01/14 17:03:21 net/http: timeout awaiting response headers
2018/01/14 17:04:23 net/http: timeout awaiting response headers
2018/01/14 17:05:25 net/http: timeout awaiting response headers
2018/01/14 17:06:27 net/http: timeout awaiting response headers
2018/01/14 17:07:29 net/http: timeout awaiting response headers
2018/01/14 17:08:39 net/http: timeout awaiting response headers
2018/01/14 17:09:13 net/http: timeout awaiting response headers
2018/01/14 17:09:49 net/http: timeout awaiting response headers
2018/01/14 17:10:29 net/http: timeout awaiting response headers
2018/01/14 17:11:17 net/http: timeout awaiting response headers
2018/01/14 17:12:18 net/http: timeout awaiting response headers
2018/01/14 17:13:21 net/http: timeout awaiting response headers
2018/01/14 17:14:22 net/http: timeout awaiting response headers
2018/01/14 17:15:24 net/http: timeout awaiting response headers
2018/01/14 17:16:26 net/http: timeout awaiting response headers
r0wbrt commented 6 years ago

It is suspected that this has been fixed by 24512742056a1fa357a482f38448a1386bc71a91. This commit resets the timeout's of a hijacked TCP connection that previously had deadlines set on it by the HTTP server/round tripper.