search

r1cc4rdo / daily_coding_problem

Solutions to https://dailycodingproblem.com
The Unlicense
160 stars 39 forks source link

Solution to Problem 4 #10

Closed vaibhavpandey11 closed 4 years ago

vaibhavpandey11 commented 4 years ago

This solution is taken from https://github.com/vaibhavpandey11

r1cc4rdo commented 4 years ago

My solution for problem 4 is here: r1cc4rdo/daily_coding_problem/solution_04.py Anything wrong with it?

Also, note that your solution is not constant space as the problem requires. See this stackoverflow post

vaibhavpandey11 commented 4 years ago

I am really sorry. Actually, I am a student of B.Tech 1st year and I have been taught Python in my college. I found many problems of dailycodingproblem and started solving them for practice. And I thought how can I get "Stars" on my repository. So I started to pull requests.

I am new to these repositories and I don't know much about Github. And I admit that I don't know much about time and space complexity as well.

Really sorry, if I disturbed you. Pardon me.

On Fri, May 15, 2020, 23:11 r1cc4rdo notifications@github.com wrote:

My solution for problem 4 is here: r1cc4rdo/daily_coding_problem/solution_04.py https://github.com/r1cc4rdo/daily_coding_problem/blob/master/problems/04/solution_04.py Anything wrong with it?

Also, note that your solution here is not constant space as required. See this stackoverflow post https://stackoverflow.com/questions/48759175/what-is-the-space-complexity-of-the-python-sort/48759241

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/r1cc4rdo/daily_coding_problem/pull/10#issuecomment-629390873, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTRTLFKRAAZKA4GPNRSD23RRV5ENANCNFSM4NBWPHGA .

r1cc4rdo commented 4 years ago

Hey, no problem man :) I'm afraid the only recipe for getting stars is to put out content good enough for others to like. Not that I necessarily think amassing internet points is a worthwhile goal though ;)

Pull requests (PRs) are for contributing to a project. Typically, you fork a project, solve some outstanding problem or improve something, and ask the original owner to include your changes in the original repository (hence, Pull Request).

Closing this one now. Take care!

vaibhavpandey11 commented 4 years ago

Thanks for your kind advice. I will definitely follow this in future.

Thank you.

On Sat, May 16, 2020, 00:12 r1cc4rdo notifications@github.com wrote:

Hey, no problem man :) I'm afraid the only recipe for getting stars is to put out content good enough for others to like. Not that I necessarily think amassing internet points is a worthwhile goal though ;)

Pull requests (PRs) are for contributing to a project. Typically, you fork a project, solve some outstanding problem or improve something, and ask the original owner to include your changes in the original repository (hence, Pull Request).

Closing this one now. Take care!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/r1cc4rdo/daily_coding_problem/pull/10#issuecomment-629417571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AOTRTLAXKYTPEVZPCJMVRFTRRWEI5ANCNFSM4NBWPHGA .