search

r1chardj0n3s / parse

Parse strings using a specification based on the Python format() syntax.
http://pypi.python.org/pypi/parse
MIT License
1.71k stars 101 forks source link

Actually raise exception #196

Closed shenanigansd closed 1 week ago

shenanigansd commented 1 week ago

Hello from https://www.pythondiscord.com/ 👋🏻 We had someone come into our Discord server today asking if this was correct. Looks like it's missing a raise, so here's a quick PR.

bendichter commented 1 week ago

Thanks for catching this!

wimglenn commented 1 week ago

Yes thanks, this does look like an oversight and test coverage miss. I wonder if the branch is actually reachable (without calling strf_date_convert directly, of course).