r1pexpb / timthumb

Automatically exported from code.google.com/p/timthumb
0 stars 0 forks source link

accentued characters get's messed up #75

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. use accentuated character in you're file pathname
2. call timthumb with either <img
src="thumb.php?src=Jos%C3%A9-Vas.jpg&amp;h=50&amp;w=50&amp;zc=0&amp;q=80">
or, in the url bar: thumb.php?src=JoséVas.jpg&h=50&w=50&zc=0&q=80

What is the expected output? What do you see instead?
I should see the image, instead I get a file_exists() error :
"file not found Bibliotheca-José-Vasconcelos1.jpg"

What version of the product are you using? On what operating system?
1.12

Please provide any additional information below.
The cause is the htmlentities which should probably not appear here.
(Anyway I'm curious about the reasons and its use)

Original issue reported on code.google.com by gibbo...@gmail.com on 15 Mar 2010 at 4:51

GoogleCodeExporter commented 9 years ago
I simply removed that line (waiting explanations about its real use).
I'm also used to pass an urldecode() to filepaths I want TimThumb to be fed 
with.

Original comment by gibbo...@gmail.com on 26 Mar 2010 at 10:45

Attachments:

GoogleCodeExporter commented 9 years ago
Hi - thanks for the pointer. I have now fixed this issue in the current 
version. If
memory serves me correctly the htmlentities code was added to stop people from 
being
able to inject script tags into image paths. I have now swapped to "strip_tags"
instead which should still stop this issue from occuring

Thanks

Original comment by BinaryMoon on 26 Apr 2010 at 8:52