Would someone mind reviewing this PR? It fixes a bug where the "new highscore" popup was not closed automatically due to higher preference of ClosePage over HighScore which sadly also matches the highscore popup. I also removed "Slow calculation" because it does nothing anymore. And I changed bubble detection so it should trigger for chains of exactly 7, too.
Is that PR okay, do I miss something or is it even unacceptable due to changes I did? I just got my dev environment running and haven't touched JavaScript for years, so please don't be too harsh with me 😊
Hi,
Would someone mind reviewing this PR? It fixes a bug where the "new highscore" popup was not closed automatically due to higher preference of
ClosePageoverHighScorewhich sadly also matches the highscore popup. I also removed "Slow calculation" because it does nothing anymore. And I changed bubble detection so it should trigger for chains of exactly 7, too.Is that PR okay, do I miss something or is it even unacceptable due to changes I did? I just got my dev environment running and haven't touched JavaScript for years, so please don't be too harsh with me 😊
Kind regards, Marcus