search

r2-studio / robotmon-scripts

Run Javascript on Android. Screenshot, Touch, ...
Apache License 2.0
78 stars 66 forks source link

Update friendPageGoTop sleep time to 3.5s #501

Closed justmaker closed 6 months ago

justmaker commented 8 months ago

2.5 seconds is not enough for the friend page sliding and stop, it let send heart easily to click on wrong place, I give it extra 1 second to reduce the probability it happens

mcs commented 8 months ago

Hi @justmaker

In this form, the change won't be rolled out to the public because it misses an index.zip file with the updated index.js file. Additionally there currently is #500 open with lots of changes. As your change looks okay to me, I can offer to merge your change into my pull request and rebuild the zip so it will also contain this change here. Or maybe the person who will merge this and maybe my pull request might run the build.sh script after the merge(s) as a separate commit so that all code changes will be part of the zip.

justmaker commented 8 months ago

@mcs It's okay to merge my change into your pull request. Is there anything I need to do?

mcs commented 8 months ago

My PR has already been merged. So probably the best way is that you rebase your branch on r2-studio's master branch, then use the build.sh script to create an up-to-date index.zip file. If you push that (either as a single commit or amended into the existing one), then it should be mergable without further conflicts. I don't know if it is technically necessary to increase any version numbers in order to make it available for the public, but probably @poi5305 knows.

If you absolutely cannot run Bash Shell scripts on your computer (no Git Bash and no NPM), then I can cherry pick your commit so it will be part of the next PR when I create one. But that might take some days or weeks until the current feature I work on is stable enough to get released for the public (auto buy boxes).

justmaker commented 8 months ago

@mcs I merged latest master and updated the index.zip generated by executing scripts/com.r2studio.TsumBeta/build.sh.

Just a question, how to verify that index.zip is correct?

mcs commented 8 months ago

@justmaker Looks good for me 👍

mcs commented 7 months ago

Your commit efc59615c32b774730826693c3aca26f5ee16138 is now on master and released within version 63, so this PR can be closed.

Sean-Hsueh commented 6 months ago

Close per comment by mcs (thanks @justmaker @mcs )