Probably erroneous usb_endpoint_address_cdc_0_interrupt usage

r2axz / bluepill-serial-monster

USB to 3 Port Serial (UART) adapter firmware for STM32 Blue Pill.

MIT License

323 stars 76 forks source link

Probably erroneous usb_endpoint_address_cdc_0_interrupt usage #58

Closed vnodeng closed 2 years ago

vnodeng commented 2 years ago

The usb_descriptors.c file at line 333 refers to the usb_endpoints parameters array via usb_endpoint_address_cdc_0_interrupt constant, which is a bit suspicious because this is done in the descriptor of third UART. This doesn't affect current functionality because parameters of control endpoints happens to match, but introduces minor inconsistency.

r2axz commented 2 years ago

Yes, you are right. I actually also noticed this and already fixed in #57.

vnodeng commented 2 years ago

Ok, missed it, because github search is a bit flawed regarding the pull request details.