search

r2dbc / r2dbc-mssql

R2DBC Driver for Microsoft SQL Server using TDS (Tabular Data Stream) Protocol
Apache License 2.0
178 stars 32 forks source link

Remove deprecated `RowMetadata.getColumnNames()` method #247

Closed mp911de closed 2 years ago

mp911de commented 2 years ago

Fixed via 8696e12.

mofeed-hassan commented 2 years ago

@mp911de Hello Mark, I am new to R2DBC and I faced while developing the problem mentioned here (depricated method problem). I am using r2dbc-bom with vesion Borca-SR1. May I ask if this problem is already resolved or not? If yes which version of r2dbc should I use? I appreciate your help so much.

mp911de commented 2 years ago

There was no problem in the first place. This ticket is about removing a deprecated method for version 1.0.

mofeed-hassan commented 2 years ago

Thanks for the fast reply. The point is that I am facing the exception "Failed to obtain R2DBC, this publisher does not support multiple subscribers". During search I understood that the cause is the method connectionPool.create() returns a Mono connection that has already subscribed to. Ref.: "https://github.com/oracle/oracle-r2dbc/issues/29" . I used the r2dbc-bom version [Borca-SR1] as it should contain the Oracle r2dbc fix for it, but it raises the exception of "This method is deprecated for removal". As Understand this method is now removed, so I am expecting r2dbc version that has solution for the original exception without the side effects of depricating RowMetadata.getColumnNames(), and that was my question is there such a version expected? Sorry for long description, but I wanted to clarify as much as possible. Thanks for help.

mp911de commented 2 years ago

Please note that this repository hosts the SQL Server driver, not the Oracle one. The deprecation you mentioned is part of the R2DBC spec itself.