r2dbc / r2dbc-mssql

R2DBC Driver for Microsoft SQL Server using TDS (Tabular Data Stream) Protocol

Apache License 2.0

183 stars 32 forks source link

Update RpcQueryMessageFlow.java to fix the bug #276 #273 #287

Open adamgongca opened 9 months ago

adamgongca commented 9 months ago

276 #273

Make sure that:

[x] You have read the contribution guidelines.
[x] You have created a feature request first to discuss your contribution intent. Please reference the feature request ticket number in the pull request.
[x] You use the code formatters provided here and have them applied to your changes. Don't submit any formatting related changes.
[x] You submit test cases (unit or integration tests) that back your changes.

Issue description

New Public APIs

Additional context

Signed-off-by: Adam Gong adam.gong.ca@gmail.com

aironi commented 6 months ago

What's the status of this PR? Will it fix the bug #273 and #276 ?

I am anxious for new version 1.0.3 to be released since we are forced to use 1.0.0 due to 1.0.2 not working. We still get #245 with 1.0.0 in certain cases but due to other bugs (#273 and #276) the 1.0.2 is not working and not usable to us.

adamgongca commented 6 months ago

What's the status of this PR? Will it fix the bug #273 and #276 ?

I am anxious for new version 1.0.3 to be released since we are forced to use 1.0.0 due to 1.0.2 not working. We still get #245 with 1.0.0 in certain cases but due to other bugs (#273 and #276) the 1.0.2 is not working and not usable to us.

I'd like to submit the PR, but the system always tell me the comment existed some problem. I had to give up. if you still have problem, please take a look at my solutions, I recommend the second one. thanks.

savuori commented 6 months ago

@adamgongca

The error is: "Commit sha: e41d301, Author: Adam Gong, Committer: GitHub; Expected "Adam Gong 43736198+adamgongca@users.noreply.github.com", but got "Adam Gong adam.gong.ca@gmail.com"."

Looks like you might be using your github private email when commiting but DCO expects the GPG signature's email and commiter emails to be the same.

https://docs.github.com/en/authentication/troubleshooting-commit-signature-verification/using-a-verified-email-address-in-your-gpg-key

You might be able to use git amend to change your commit's email to match the GPG identity's email address.