search

r2dbc / r2dbc-pool

Connection Pooling for Reactive Relational Database Connectivity
https://r2dbc.io
Apache License 2.0
332 stars 55 forks source link

Wrong information in README.md #130

Closed frombrest closed 3 years ago

frombrest commented 3 years ago

In README.md we have table with description of ConnectionPoolConfiguration options.

Has such phrase in description: Negative values indicate no timeout

At the same time ConnectionPoolConfiguration.Builder has checks for that values and they could not be null, or negative Ex:

    public ConnectionPoolConfiguration.Builder maxIdleTime(Duration maxIdleTime) {
        Assert.requireNonNull(maxIdleTime, "maxIdleTime must not be null");
        if (maxIdleTime.isNegative()) {
            throw new IllegalArgumentException("maxIdleTime must not be negative");
        } else {
        // . . .

Do we need to correct they to Zero (PT0S) values indicate no timeout ?

mp911de commented 3 years ago

What you see is a difference between 0.8.x (0.8.x branch) and 0.9.x (main branch). We changed the no timeout/zero-timeout behavior with #77 for the 0.9.x development line.