Should BACKGROUND_EVICTION_INTERVAL be of type Option<Duration>

r2dbc / r2dbc-pool

Connection Pooling for Reactive Relational Database Connectivity

https://r2dbc.io

Apache License 2.0

331 stars 55 forks source link

Should BACKGROUND_EVICTION_INTERVAL be of type Option<Duration> #180

Closed duyleekun closed 1 year ago

duyleekun commented 1 year ago

https://github.com/r2dbc/r2dbc-pool/blob/dae00e57f5509a7fea769df6ea116fd85a4c990b/src/main/java/io/r2dbc/pool/PoolingConnectionFactoryProvider.java#L60

I'm unable to set BACKGROUND_EVICTION_INTERVAL via ConnectionFactoryOptions.builder().option(PoolingConnectionFactoryProvider.BACKGROUND_EVICTION_INTERVAL,XXXX)

Seem like XXXX can only be Integer and internally, it requires it to be either String or Duration. Am I missing something?

mp911de commented 1 year ago

Good catch, do you want to submit a pull request to fix that issue?