search

r2dbc / r2dbc-pool

Connection Pooling for Reactive Relational Database Connectivity
https://r2dbc.io
Apache License 2.0
337 stars 55 forks source link

Added missing options to PoolingConnectionFactoryProvider #69

Closed rodolphocouto closed 4 years ago

rodolphocouto commented 4 years ago

I need to customize some options, so I added them to PoolingConnectionFactoryProvider:

These options expect a Duration type, so I created an utility class to parse them. It only supports the ISO-8601 format for now, but if you want, I can implement support for other formats like DurationStyle from Spring Boot conversion service.

mp911de commented 4 years ago

Thanks for the pull request. We currently default in R2DBC to the Duration ISO-8601 format where durations are parsed. Introducing a specific format parser in each project leads to code duplication across all drivers. While a more user-friendly format is desirable, a parser should be provided ideally by the Java runtime itself.

mp911de commented 4 years ago

Thank you for your contribution. That's merged, polished, and backported now.