r3-team / r3

REI3 - Free and open low code
https://rei3.de
MIT License
349 stars 46 forks source link

Button on edit/create form #10

Closed fabiograz closed 2 years ago

fabiograz commented 2 years ago

Hi, when I click on new button (i.e. in Country list form in Location application) new form are displayed. In this form there is a "delete" button, but it is greyed. It become red only after saved the new record. I expected that it was an abort button, so if I don't want insert the record I can abort and return on the previous form (in this case the country list form). So also the "new" button is not useful in case I add a new record. In fact in this case if I insert a new record and press "new" I discard any inserted values. I think that this buttons must better managed to simplify the user workflow. For example the form button may be: "new": in case there are any new values inserted by user a confirmation message must be showed so user may cancel operation "save": as now, but if I modify a record a confirmation message must be displayed (this may be a configuration parameter) "Save + new": as now and as suggested for the "save" button "Delete: as now, but after confirmation must be shown next/previews or last record "Exit": in this case, after a user confirmation in case of modified values on the form, application return to a predefined form (i.e. list)

In this manner the workflow is more clear. What do you think about?

Bye, Fabio.

r3-gabriel commented 2 years ago

Hello Fabio,

With some suggestions I agree, others I think are more like personal preference. In order:

To summarize, I suggest:

What do you think?

Warm regards,

Gabriel

fabiograz commented 2 years ago

Hi, I agree with your suggestions. The message for the "save" button should be for informational purposes only and appear for a few seconds to indicate that the operation was successful (as well as in the event of an error). For the exit button it is important that it can be defined which form to return to. Best regard, Fabio

r3-gabriel commented 2 years ago

Hello Fabio,

then I will implement the changes for 2.5.1, which was already on its way to the finish line.

Regarding the exit/go-back button: The implementation I had in mind uses the browser history with REI3´s page router - which not only knows the previous form but would also set a list scroll position (if previous form was a list) to the last known value and recreate sorting and simple filters. Setting the form manually could be error prone - you can forget to change this and you can also reach the same form from 2 different places.

Warm regards,

Gabriel

fabiograz commented 2 years ago

Hello Gabriel, ok for your implementation. I've translated new messages to Italian

Thanks.