search

r38y / griddler-postmark

Postmark adapter for the Griddler gem
MIT License
9 stars 17 forks source link

Making use of StrippedTextReply #10

Closed dyerc closed 7 years ago

dyerc commented 7 years ago

It doesn't look as though the StrippedTextReply parameter which postmark sends over is currently used. It is documented here: http://developer.postmarkapp.com/developer-process-parse.html

I would be happy to put together a pull request but I wasn't sure if it was appropriate or if there is a reason StrippedTextReply isn't currently used. Do you think normalized_params returning an extra key with the stripped text reply is the best way to handle it?

r38y commented 7 years ago

Hey, sorry for the delayed response, only now getting down to that part of my inbox 😬

There is support in Griddler master now for vendor-specific fields: https://github.com/thoughtbot/griddler/blob/master/lib/griddler/email.rb#L47

I don't think it's documented yet but I think it is appropriate to put it in there, what do you think?

dyerc commented 7 years ago

Thanks @r38y, that solution looks perfect to me. I would be happy to put a pull request together if you like, but it wouldn't be until the week after next?

r38y commented 7 years ago

Sounds great :) thanks!

On Fri, Jul 7, 2017 at 09:10 Chris Dyer notifications@github.com wrote:

Thanks @r38y https://github.com/r38y, that solution looks perfect to me. I would be happy to put a pull request together if you like, but it wouldn't be until the week after next?

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/r38y/griddler-postmark/issues/10#issuecomment-313693064, or mute the thread https://github.com/notifications/unsubscribe-auth/AAADntU3qR5a3ZOsJMRDMavaGJsD0TMTks5sLjxFgaJpZM4OCDgZ .

-- Randy Schmidt

serene commented 7 years ago

Resolved with PR #11.